On Tue, 15 Jul 2025 16:29:11 GMT, Justin Lu <[email protected]> wrote:
>> cagliostro92 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8358530: adds warnings against non-String values in Properties class
>> documentation
>
> src/java.base/share/classes/java/util/Properties.java line 78:
>
>> 76: * the call to the {@code propertyNames} or {@code list} method
>> 77: * will fail if it is called on a "compromised" {@code Properties}
>> 78: * object that contains a non-{@code String} key or value.
>
> Since `propertyNames` won't throw `CCE` with a non-String value, instead of
> adding the "or value" wording here, we should move the `list` method to the
> sentence above and remove it from the current sentence.
>
> E.g., on line 73
>
>> "If the {@code store}, {@code save}, or {@code list) method ...
My bad, sorry. Fixed with 8d7e3d2fde65bd1e4ad85eca5ea93a430e2e8238
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25334#discussion_r2210484938
