On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway <d...@openjdk.org> wrote:
> Refactored extract method to encapsulate Windows specific test logic test/jdk/java/io/File/MaxPathLength.java line 62: > 60: > 61: // test long paths on windows > 62: // And these long pathes cannot be handled on Solaris and Mac > platforms I assume this command should be updated to say Linux. test/jdk/java/io/File/MaxPathLength.java line 196: > 194: } > 195: > 196: private static void testLongPathOnWindows () throws Exception { Just a drive-by comment to say that naming it testLongPath and keeping the isWindows check in main would be a bit more readable. That will fit with the existing comment in main. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26193#discussion_r2221456217 PR Review Comment: https://git.openjdk.org/jdk/pull/26193#discussion_r2221455815