On Thu, 24 Jul 2025 10:06:39 GMT, Darragh Conway <[email protected]> wrote:
>> There were a couple of post review comments after the /integrate command was
>> submitted. This issue will address those comments. Also created constants
>> for hardcoded values and tests. Fixed some typos.
>
> Darragh Conway has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix remaining indentation errors (From my first commit on this branch)
test/jdk/java/io/File/MaxPathLength.java line 69:
> 67: }
> 68:
> 69: private static void setIsWindows() {
Instead of `isWindows` and `setIsWindows`, perhaps you should consider using
`jdk.test.lib.Platform.isWindows()`? See, for example,
[GetXSpace.java](https://github.com/openjdk/jdk/blob/master/test/jdk/java/io/File/GetXSpace.java),
lines 30-31, 46, and 109.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26445#discussion_r2240679861
