On Tue, 29 Jul 2025 14:49:33 GMT, Roger Riggs <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename getRawClassAccessFlags to getClassFileAccessFlags and fix the test
>> to reflect what the JVM does.
>
> src/java.base/share/classes/java/lang/Class.java line 4143:
>
>> 4141: * {@code FINAL}.
>> 4142: * If this {@code Class} object represents an array type return
>> 0. This
>> 4143: * is not called in Class but can be called with an array type in
>> Reflection.
>
> The comment about "not called in Class" may get stale. I don't think it needs
> to be specified.
Okay, I'll remove it. I wanted to explain the change of the algorithm, and why
I removed the handling for arrays.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26517#discussion_r2240785622