On Wed, 3 Sep 2025 17:41:32 GMT, David Beaumont <[email protected]> wrote:
>> @david-beaumont I think you need to override `getLocation` if you override >> `isResource` so image reader can actually fetch the data - unfortunately >> this is not clearly documented. > > Ooooh. That's interesting. > So before, these nodes were none of the types resource, directory or link. > And obviously that was working to an extent. > And you're right that "isResource()" should imply "getResource()" works, but > if that's the case, how can a JRT file system be built on top of this at all? > I need to investigate more... Ah no, there is not, and never was a "getResource()" method on the node class. Nodes are not inner classes and do not have access to the image. The getResource() method exists (both now and before my changes) on the ExplocedImage class. So I think what I've done here is correct, and no other changes are necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26757#discussion_r2319731082
