On Wed, 2 Jul 2025 11:15:00 GMT, Armin Schrenk <[email protected]> wrote:

> Add support for native ARM64 Windows MSI pacakges to jpackage.
> 
> For some reasoning and more info, check out the ticket on JBS: 
> https://bugs.openjdk.org/browse/JDK-8361207.

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java line 
210:

> 208:             case Arch.X86 -> "x86";
> 209:             case Arch.AARCH64 -> "arm64";
> 210:             case Arch.OTHER -> throw new IOException("Unsupported 
> architecture.");

This would rather be an instance of `UnsupportedOperationException`

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java line 
264:

> 262:             case Arch.X64 -> "x64";
> 263:             case Arch.X86 -> "x86";
> 264:             case Arch.AARCH64, Arch.OTHER -> throw new 
> IOException("Unsupported architecture.");

Is aarch64 packaging unsupported by WiX3?

-------------

PR Review: https://git.openjdk.org/jdk/pull/26093#pullrequestreview-3182672122
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r2320331550
PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r2320329066

Reply via email to