On Tue, 16 Sep 2025 09:25:21 GMT, Andrew Dinn <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude more GC heap size tests as AOT cache size has increased for "make
>> test JTREG=AOT_JDK=onestep ..."
>
> src/hotspot/share/cds/aotMetaspace.cpp line 806:
>
>> 804: AOTClassInitializer::init_test_class(CHECK);
>> 805:
>> 806: if (CDSConfig::is_dumping_final_static_archive()) {
>
> What is the reason for moving this earlier to before link_all_loaded_classes?
I added comment about the order of this code vs link_all_loaded_classes().
Before switching the order, I found that in some rare cases classes were
removed from the AOT cache because they are unlinked after
`FinalImageRecipes::apply_recipes()`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27024#discussion_r2353226013
