On Thu, 18 Sep 2025 20:52:43 GMT, Pavel Rappo <[email protected]> wrote:
>> Okay -- while some of the changes here are clearly bugs, that doesn't >> obviate the need for a quick CSR review. >> >> Regarding _integer_ values, 0 is conventionally neither positive nor >> negative; it stands alone, hence Math.signum(int): >> >> "Returns the signum function of the specified int value. (The return value >> is -1 if the specified value is negative; 0 if the specified value is zero; >> and 1 if the specified value is positive.)" >> >> Therefore, "non-negative" integers include zero while "positive" integers do >> not. > > @jddarcy, are you okay with me pushing this without CSR? To my mind, it now > contains typo fixes and editorial improvements only. @pavelrappo `Period.isNegative()` would be used in validation, to ensure that the period you are receiving only has components that are >= 0. One can certainly argue about the method name, but c'est la vie... ------------- PR Comment: https://git.openjdk.org/jdk/pull/27296#issuecomment-3314755059
