On Fri, 12 Sep 2025 16:13:30 GMT, Jaikiran Pai <[email protected]> wrote:
> Hello Aleksei, I have updated the PR to implement your suggestion 1 and 2. As > for the other suggestion of moving these constants to the `LDAPTestUtils` > test library class, I think that's a good idea too. However, I gave that a > try and that isn't straightforward. Once I move them to that class, jtreg > then requires me to add a `@build` and a `@library` instruction to bring in > the `test.LDAPServer` class which the `LDAPTestUtils` uses (but not this new > test). That wouldn't be too bad and I did add those, but then `LDAPTestUtils` > has an import of an internal class: > > ``` > import com.sun.jndi.ldap.LdapURL > ``` > > so that then forces me to reintroduce the: > > ``` > @modules java.naming/com.sun.jndi.ldap > ``` > > in this new test, which I think defeats the entire cleanup. So I decided to > leave those constants this in this test class for now and reconsider that > move as a future work. Would that be OK? Oh, it is complicated, thank you for trying to move the constants. I agree that it defeats the entire cleanup initiative and doesn't worth the effort. It is OK to leave the constants in the test class. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25449#issuecomment-3285926413
