On Mon, 22 Sep 2025 17:55:22 GMT, Chen Liang <[email protected]> wrote:
>> I mentioned this in the PR description because it is necessary to change a >> small number of tests ro run in /othervm mode. This is because jtreg >> reflectively opening a package isn't sufficient, it has to run the test with >> `--add-opens`. > > Do you think we should update jtreg to fail in the future if `@modules` is > specified without othervm, like how `@enablePreview` works today? No, we need to allow jtreg continue to use its injected JTRegModuleHelper to do this, otherwise it would mean a lot more forking of VMs in test runs for the sake of the tiny number of tests that are hacking finals. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25115#discussion_r2369695722
