On Mon, 22 Sep 2025 22:56:55 GMT, Justin Lu <[email protected]> wrote:
> Please review this PR which finishes the conversions of _TestNG_ to _JUnit_
> within the Locale tests. (Primarily under bcp47u with a few other
> stragglers.) Tests pass as before. The same number of tests completed in the
> test results section remain the same.
>
> test/jdk/java/util/Locale/LocaleMatchingTest.java
> test/jdk/java/util/Locale/RequiredAvailableLocalesTest.java
> test/jdk/java/util/Locale/TestOf.java
> test/jdk/java/util/Locale/bcp47u/CalendarTests.java
> test/jdk/java/util/Locale/bcp47u/CurrencyFormatTests.java
> test/jdk/java/util/Locale/bcp47u/CurrencyTests.java
> test/jdk/java/util/Locale/bcp47u/DisplayNameTests.java
> test/jdk/java/util/Locale/bcp47u/FormatTests.java
> test/jdk/java/util/Locale/bcp47u/SymbolsTests.java
> test/jdk/java/util/Locale/bcp47u/SystemPropertyTests.java
LGTM
test/jdk/java/util/Locale/LocaleMatchingTest.java line 349:
> 347: assertNotEquals(lr1, lr4, " LR(ja, 1.0).equals(LR(en, 1.0))
> should return false.");
> 348: assertNotNull(lr1, " LR(ja, 1.0).equals(null) should return
> false.");
> 349: assertNotEquals("", lr1, " LR(ja, 1.0).equals(\"\") should
> return false.");
Nit: If we change the unexpected and actual, probably do the same for L346/347
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27441#pullrequestreview-3258892144
PR Review Comment: https://git.openjdk.org/jdk/pull/27441#discussion_r2372938597
