On Wed, 1 Oct 2025 17:45:41 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>> to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and
>> ensure they are closed on exiting the block. By implementing
>> `AutoClosable.close()` the completeness of closing the streams and process
>> termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the
>> process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clarify the use of waitFor after close() or T-W-R exit.
src/java.base/share/classes/java/lang/Process.java line 190:
> 188: * If the process should be allowed to run to completion or the exit
> value of the process
> 189: * is of interest, then the caller must {@linkplain #waitFor() wait}
> for the process
> 190: * to complete before calling this method.
I understand there is a follow-up JBS issue created to get the terminology in
the Process API docs consistent. On this one, I think we should say it must
wait until the process has terminated as that is how waitFor is specified.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2403786352
