On Sat, 18 Oct 2025 04:34:54 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Minor changes, no functional impact. >> >> - ApplicationBuilder: add externalApplication() and mainLauncherClassName() >> methods >> - `AppImageSigner.normalizeAppImageLayout()` -> >> `AppImageSigner.copyWithUnresolvedAppImageLayout()` >> - Add `JLinkRuntimeBuilder.ensureBaseModuleInModulePath()`; move code away >> from StandardBundlerParam; remove redundant "warning.no.jdk.modules.found" >> string ID >> - Add `OverridableResource.probe()` method >> - Remove dead and "odd" code from IOUtils > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains nine commits: > > - Merge branch 'master' into JDK-8370123 > - JLinkRuntimeBuilder: remove trailing whitespace > - JLinkRuntimeBuilder: add a comment > - IOUtils: remove dead code; remove getFileName(), getParent() functions. > - ApplicationLaunchers: minor > - OverridableResource: add probe() method > - Add JLinkRuntimeBuilder.ensureBaseModuleInModulePath() > - AppImageSigner: better function name > - ApplicationBuilder: add externalApplication() and mainLauncherClassName() > methods Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27873#pullrequestreview-3358408932
