On Wed, 22 Oct 2025 19:57:17 GMT, Roger Riggs <[email protected]> wrote:
>> Xueming Shen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test case update
>
> make/jdk/src/classes/build/tools/generatecharacter/CaseFolding.java line 60:
>
>> 58: cp,
>> 59: Arrays.stream(folding)
>> 60: .mapToObj(f ->
>> String.format("0x%04x", f))
>
> For each string in fields do the parsing and formatting here; skipping the
> extra array.
> Or just use the string from fields[i]; the parse and format seems like a
> no-op except for catching file format errors.
updated to use the input stream directly
> src/java.base/share/classes/java/lang/StringLatin1.java line 217:
>
>> 215: if (c1 != c2) {
>> 216: return c1 - c2;
>> 217: }
>
> Compute difference only once.
> Suggestion:
>
> if ((c1 - c2) != 0) {
> return c1 - c2;
> }
you meant go with
if ((c1 - c2) != 0) {
return c1 - c2;
} ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27628#discussion_r2465004392
PR Review Comment: https://git.openjdk.org/jdk/pull/27628#discussion_r2464997505
