On Fri, 24 Oct 2025 14:00:33 GMT, Coleen Phillimore <[email protected]> wrote:

>> I added `patch_pd_unused` in 8359222 which should have been 
>> `patch_unused_pd`. :)
>
> I like AnchorMark.  There are other places that clear_anchor in this code.  
> Can they use AnchorMark?

Yes, I added it in `ThawBase::throw_interrupted_exception()` and in 
`thaw_fast()`.

>> A full `HandleMark` works too. It’s just that there is already a 
>> `HandleMark` in the callstack (from the original upcall to Java from the 
>> carrier thread), so we can use a `HandleMarkCleaner` here.
>
> The main place we have HandleMarkCleaners are in the JRT_ENTRY.  Can you 
> change the comment to:
> // Returning to java so cleanup all handles including so._conth Handle
> 
> or something like that.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2466823846
PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2466820533

Reply via email to