On Tue, 4 Nov 2025 17:53:36 GMT, Naoto Sato <[email protected]> wrote:

>> Upgrading the CLDR to version 48.0. A corresponding CSR has also been 
>> drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Minor header fix

Took a look at all the changes besides the XML data itself. LGTM.

make/data/cldr/LICENSE line 1:

> 1: UNICODE LICENSE V3

I guess a line ending change on their end?

make/jdk/src/classes/build/tools/cldrconverter/Bundle.java line 852:

> 850: 
> 851:     /**
> 852:      * Escape reserved pattern characters, '#', '{', and '}' in the 
> pattern

Even though they may not be offending now, should  '[' and ']' be included 
since they are also non CLDR date time patterns (not A-Z), but are recognized 
in DateTimeFormatter patterns?

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/28076#pullrequestreview-3412376711
PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2491900624
PR Review Comment: https://git.openjdk.org/jdk/pull/28076#discussion_r2491874764

Reply via email to