On Tue, 4 Nov 2025 10:33:27 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which cleans up the outdated enum > constants in the internal `jdk.internal.javac.PreviewFeature$Feature` enum? > > This addresses https://bugs.openjdk.org/browse/JDK-8365699. As noted in that > issue, this enum has accumulated some outdated preview feature constants > which are no longer needed. The changes in this PR removes those enum > constants whose preview features have been finalized in Java 25 or earlier > (the current mainline bootstrap JDK is Java 25). A code comment explaining > the lifetime of these enum constants has also been added. > > No new tests have been introduced and tier1, tier2, tier3 testing is > currently in progress in the CI. This pull request has now been integrated. Changeset: 188da51f Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/188da51f30e5ca3945fee91fe2e94f0466151c06 Stats: 23 lines in 1 file changed: 15 ins; 6 del; 2 mod 8365699: Remove jdk.internal.javac.PreviewFeature.Feature enum values for features finalized in Java 25 or earlier Reviewed-by: vromero, liach ------------- PR: https://git.openjdk.org/jdk/pull/28128
