On Mon, 10 Nov 2025 13:55:33 GMT, Jorn Vernee <[email protected]> wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Split test steps
>
> test/jdk/tools/jar/ValidatorTest.java line 354:
>
>> 352: jar("--validate --file " + path);
>> 353: fail("Expecting non-zero exit code validating: " + path);
>> 354: } catch (IOException e) {
>
> It's just that `jar` method that throws the expected exception, right? Could
> you limit the length of the `try` block to not cover the nested try block?
> Otherwise, if `JarInputStream` starts throwing the same exception, this test
> would stop testing the `jar` method. (also I think it makes it a little
> clearer which line is expected to throw)
Applied in
https://github.com/openjdk/jdk/pull/28154/commits/28068ea6bf7b95fa6427cf644102ba3df9c3fa32
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28154#discussion_r2515301732
