On Fri, 31 Oct 2025 14:00:38 GMT, Justin King <[email protected]> wrote:
> Check whether `osSupport::map_memory` actually succeeded in all compliation
> modes, instead of crashing shortly after in non-debug builds. Ideally we
> should fall back to just reading the entire file into memory manually or use
> seek+read, but this is good enough for now to avoid crashing.
src/java.base/share/native/libjimage/imageFile.cpp line 335:
> 333: _index_data = (u1*)osSupport::map_memory(_fd, _name, 0,
> (size_t)map_size());
> 334: if (_index_data == nullptr) {
> 335: return false;
Indentation in this file is 4 spaces.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28087#discussion_r2520210679
