On Mon, 17 Nov 2025 06:37:15 GMT, Fei Yang <[email protected]> wrote:
>> Hamlin Li has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - add CMove+CmpP/N tests >> - fix cmovF/D_cmpP > > src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2133: > >> 2131: break; >> 2132: case BoolTest::ge: >> 2133: assert(false, "Should go to BoolTest::le case"); > > I am not sure if it's safe to have these assertions for `ge` and `gt`. It > seems to me that we should handle all possible condition codes here. Check > this bug: https://bugs.openjdk.org/browse/JDK-8358892. We have added handling > for `ge` and `gt` in `C2_MacroAssembler::enc_cmove_cmp_fp` to fix it. Make sense! Thanks! I'll add the implementation for these condition codes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28309#discussion_r2534113207
