On Wed, 19 Nov 2025 07:40:10 GMT, Adam Sotona <[email protected]> wrote:
>> Chen Liang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> 8372047: ClassTransform.transformingMethodBodies andThen composes
>> incorrectly
>
> src/java.base/share/classes/jdk/internal/classfile/impl/TransformImpl.java
> line 123:
>
>> 121: @Override
>> 122: public ClassTransform andThen(ClassTransform next) {
>> 123: if (next instanceof ClassMethodTransform(var nextTransform,
>> var nextFilter) && filter == nextFilter)
>
> I'm trying to figure out a case where filters of the chained transforms are
> identical.
> Is it covered by some tests?
> Unless there is a real benefit in a frequent use case I suggest to remove
> this optimization.
This is only intended for the no-filter transform, which uses the same
stateless lambda.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28377#discussion_r2542016226
