On Thu, 13 Nov 2025 06:46:51 GMT, Patrick Strawderman <[email protected]> wrote:
>> When `Comparator.naturalOrder()` was explicitly supplied to a collection >> such as `TreeSet`, or passed into the `sorted` method of a stream, the >> sorted characteristic was not preserved, causing unnecessary buffering and >> duplicate sorting. >> >> Example: >> >> >> TreeSet<Integer> sortedSet = new TreeSet<>(Comparator.naturalOrder()); >> sortedSet.add(1); >> sortedSet.add(2); >> // SortedOps.OfRef.opWrapSink is not a no-op >> sortedSet.stream().sorted().forEach(System.out::println); >> >> or >> >> TreeSet<Integer> sortedSet = new TreeSet<>(); >> sortedSet.add(1); >> sortedSet.add(2); >> // SortedOps.OfRef.opWrapSink is not a no-op >> sortedSet.stream().sorted(Comparator.naturalOrder()).forEach(System.out::println); >> >> >> This PR updates `SortedOps.makeRef` and `StreamOpFlag.fromCharacteristics` >> to handle the above cases and avoid the unnecessary sort step. > > Patrick Strawderman has updated the pull request incrementally with one > additional commit since the last revision: > > Fix StreamOpFlagsTest Looks good, thanks! ------------- Marked as reviewed by vklang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28226#pullrequestreview-3483010086
