On Wed, 19 Nov 2025 12:52:07 GMT, Matthias Baesken <[email protected]> wrote:
>> In the review of [JDK-8333522](https://bugs.openjdk.org/browse/JDK-8333522) >> it has been discussed that we might run into issues because of failing >> sysinfo. >> However we miss checking the return values at some places, this might need >> adjustment. > > Matthias Baesken has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains five commits: > > - Merge master > - Merge remote-tracking branch 'origin/master' into JDK-8333871 > - use more asserts > - 0 - terminate not needed > - JDK-8333871 src/hotspot/os/linux/os_linux.cpp line 2436: > 2434: os::print_dhm(st, "OS uptime:", (long) sinfo.uptime); > 2435: } > 2436: assert(ret == 0, "sysinfo must return 0"); Sorry we should report the value of `errno` if the assert fails Suggestion: assert(ret == 0, "sysinfo failed: %s", os::strerror(errno)); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28317#discussion_r2544337803
