On Wed, 17 Dec 2025 19:53:00 GMT, Roger Riggs <[email protected]> wrote:
> Refactor serialization tests to use JUnit.
> Automated conversion for most annotations.
> Conditional tests are refactored to use JUnit Enable/DisableIf.
test/jdk/java/io/Serializable/class/NonSerializableTest.java line 104:
> 102: @ParameterizedTest
> 103: @MethodSource("provider")
> 104: public void test(String[][] argArray) throws Exception {
I recommend changing `provider` to return `List<String[]>` or `Object[]`,
instead of hacking the test.
test/jdk/java/io/Serializable/serialFilter/SerialFilterTest.java line 389:
> 387: Assertions.assertEquals(
> ObjectInputFilter.Status.REJECTED, filter.checkInput(new
> FilterValues(arrayClass, value, value, value, value)),
> 388: "last limit value not used: " + filter);
> 389: Assertions.assertEquals(
> ObjectInputFilter.Status.UNDECIDED, filter.checkInput(new
> FilterValues(arrayClass, value-1, value-1, value-1, value-1)),
Extra indentation from the auto conversion script
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2628680694
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2628691334
