On Wed, 17 Dec 2025 21:41:50 GMT, Chen Liang <[email protected]> wrote:
>> Refactor java/lang/invoke tests to use JUnit instead of TestNG.
>> This is done by:
>> 1. First a round of automatic conversion
>> 2. Simplify exception handling tests
>> 3. Replacing `assert` keyword and switching to better assertion APIs for
>> equality etc.
>> 4. Some other random cleanups, such as module status
>>
>> Testing: java/lang/invoke on Linux-x64. I un-problemlisted the updated
>> `java/lang/invoke/lambda/LambdaFileEncodingSerialization.java` too.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Some omissions
test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java line 298:
> 296: {
> 297: boolean x = (boolean) vh.get(recv);
> 298: assertEquals(true, x,"get boolean value");
Suggestion:
assertEquals(true, x, "get boolean value");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28879#discussion_r2631166589
