On Wed, 17 Dec 2025 09:01:09 GMT, Johannes Döbler <[email protected]> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove redundant checkField
>
> src/java.base/share/classes/java/time/format/Parsed.java line 175:
> 
>> 173:      */
>> 174:     @SuppressWarnings("unchecked")
>> 175:     Parsed(boolean onlyChronoField) {
> 
> If you know that only ChronoFields are used then imho the loop over the 
> entries of `fieldValues` in method `resolveFields`  can be skipped (line 
> 290ff).

Good suggestion, but that should be a separate PR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28471#discussion_r2633378092

Reply via email to