On Fri, 19 Dec 2025 22:07:37 GMT, Brent Christian <[email protected]> wrote:
>> `RuntimeArguments.java` runs with `@requires vm.flagless`, though setting
>> the `test.thread.factory=Virtual` system property with `-D` will still run
>> the test.
>>
>> The test spawns java processes, checking for particular, exact sets of
>> runtime options (hence, `vm.flagless`). It is not expecting to find
>> `-Dtest.thread.factory=Virtual`.
>>
>> It doesn't seem important that this test be run with the virtual thread
>> factory. The suggestion of adding this test to `ProblemList-Virtual.txt`
>> seems reasonable. (It would be a long term resident of the problem list,
>> which is perhaps a bit strange.)
>>
>> Alternative courses of action:
>> * Teach the test itself to artificially pass in the presence of `-D` options.
>> * Enhance the test so it knows how to expect `-D` options; offhand that
>> doesn't seem worth it.
>>
>> Update:
>> The bots don't like having the "current" bugid present in the problem list.
>> I have updated the bugid in the PL to 8309303 (when the `VM_OPTIONS`
>> constant was added to the test) - a bit disingenuous. If we're not happy
>> with this, I guess a new issue could be filed ("RuntimeArguments.java
>> doesn't account for -D system properties") to use in the problem list.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Change ProblemList bugid to 8309303
> It doesn't seem important that this test be run with the virtual thread
> factory.
In that case, can you add `@requires test.thread.factory == null` to the test
description. That would avoid having it permanently excluded via
ProblemList-Virtual.txt when doing JTREG_TEST_THREAD_FACTORY=Virtual test runs.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28935#issuecomment-3677514928
