On Mon, 22 Dec 2025 23:30:48 GMT, Alexander Matveev <[email protected]>
wrote:
>> Alexey Semenyuk has refreshed the contents of this pull request, and
>> previous commits have been removed. Incremental views are not available.
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/cli/StandardBundlingOperation.java
> line 71:
>
>> 69: }
>> 70:
>> 71: public boolean createBundle() {
>
> `createBundle` -> `isCreateBundleVerb`. `createBundle` is confusing. It reads
> like it should create bundle when this function is called.
I am confused about use case of this enum. It has `SIGN` which is mac specific
and has `CREATE` for create bundle which sounds generic for all platforms. Can
you explain usage of this enum, improve it is naming or document it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28957#discussion_r2641519758
