On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev <[email protected]> 
wrote:

> NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are 
> no alternative for it.

Right, but `hdiutil udifrez` command is still working:

[02:08:24.166] Running /usr/bin/hdiutil
[02:08:24.194] Command [PID: 93201]:
    /usr/bin/hdiutil udifrez testCommon/output/CommonLicenseTest-1.0.dmg -xml 
/var/folders/xt/bm4_x23d1_s0kbvvls86_7z80000gr/T/jdk.jpackage6799898339358549904/config/CommonLicenseTest-license.plist
[02:08:24.194] Output:
    hdiutil: WARNING: udifrez is deprecated
    copying resource 'STR#' (5000)...
    copying resource 'STR#' (5001)...
    copying resource 'STR#' (5002)...
    copying resource 'STR#' (5003)...
    copying resource 'STR#' (5004)...
    copying resource 'STR#' (5005)...
    copying resource 'STR#' (5006)...
    copying resource 'STR#' (5007)...
    copying resource 'STR#' (5008)...
    copying resource 'STR#' (5009)...
    copying resource 'STR#' (5010)...
    copying resource 'STR#' (5011)...
    copying resource 'STR#' (5012)...
    copying resource 'STR#' (5013)...
    copying resource 'STR#' (5014)...
    copying resource 'STR#' (5015)...
    copying resource 'STR#' (5016)...
    copying resource 'TMPL' (128)...
    copying resource 'TEXT' (5000)...
    copying resource 'LPic' (5000)...
    copying resource 'styl' (5000)...
    copying resource 'plst' (0)...
[02:08:24.195] Returned: 0

[02:08:24.195] Result DMG installer for CommonLicenseTest: 
testCommon/output/CommonLicenseTest-1.0.dmg.
[02:08:24.196] Succeeded in building Mac DMG Package package
[02:08:24.319] TRACE: exec: Done. Exit code: 0


Should we spend time cleaning the "lic_template.plist" file and adding 
complexity by moving resources to l10n files, or merely remove support for a 
license file in DMG packaging? I'm on the fence.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684915337

Reply via email to