On Fri, 26 Dec 2025 06:44:38 GMT, SendaoYan <[email protected]> wrote:
>> Hi all,
>>
>> Test jdk/internal/platform/cgroup/TestCgroupMetrics.java report fails when
>> the docker service is unavailable. The details shows in jbs issue. I think
>> it's better to call `DockerTestUtils.checkCanTestDocker()` before run this
>> test.
>>
>> Change has been verified locally. Test-fix only, no risk.
>
> SendaoYan has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fix year
> - Move DockerTestUtils.checkCanTestDocker() inside MetricsTester
test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java line 86:
> 84:
> 85: public static void main(String[] args) throws Exception {
> 86: DockerTestUtils.checkCanTestDocker();
Thanks for the update.
Can you explain why here requires docker service directly?
>From the logs in JBS, I guess the places should be where the following docker
>files are required?
Unable to open :
/sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.cfs_period_us
Unable to open :
/sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.cfs_quota_us
Unable to open : /sys/fs/cgroup/cpu,cpuacct/system.slice/sshd.service/cpu.stat
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28996#discussion_r2647686625
