On Tue, 6 Jan 2026 11:37:38 GMT, Mark Sheppard <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Mark's review - use CountDownLatch
>> - merge latest from master branch
>> - 8170896: TEST_BUG:
>> java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java
>> failed with unreferenced() not invoked after 20.0 seconds
>
> test/jdk/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java
> line 111:
>
>> 109: System.err.println("waiting for unreferenced()
>> callback...");
>> 110: callbackInvocationLatch.await();
>> 111: Instant waitEndedAt = Instant.now();
>
> 111 - 126 refactor extract method isWithinExpectedTimeLimit
> simpllifies reading of test, and lucidly expresses the logic of the time
> evaluation
Done, I've updated the PR to move the duration check into a separate method. I
let the File reading stay in this main method instead of passing around file
path to the new assert method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28919#discussion_r2665213995
