On Wed, 7 Jan 2026 13:44:53 GMT, Viktor Klang <[email protected]> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 28 additional commits >> since the last revision: >> >> - Merge branch 'openjdk:master' into JDK-8373118 >> - Split external push >> - Undo/redo ordering changes >> - Strengthen some orderings >> - Merge branch 'openjdk:master' into JDK-8373118 >> - Not sure why this merge is necessary >> Merge remote-tracking branch 'refs/remotes/origin/JDK-8373118' into >> JDK-8373118 >> - Merge branch 'openjdk:master' into JDK-8373118 >> - Fix deactivate; faster quiescence >> - recheck avoiding cross-class offsets >> - Merge branch 'openjdk:master' into JDK-8373118 >> - ... and 18 more: https://git.openjdk.org/jdk/compare/206410fe...54a8672a > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1969: > >> 1967: } >> 1968: else if (q.base == b && >> 1969: U.compareAndSetReference(a, bp, >> t, null)) { > > Would we expect a[bp] to be possible to be something besides `t` or `null` > here? If not, I think we could switch to a `U.getAndSetReference(a, bp, null) > == t` here? Narrator: it won't work since there might be other values than `t` and `null` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2668836812
