On Mon, 26 Jan 2026 21:13:10 GMT, Srinivas Vamsi Parasa <[email protected]> wrote:
>> Mohamed Issa has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into user/missa-prime/avx10_2 >> - Merge branch 'master' into user/missa-prime/avx10_2 >> - Change function names and extend IR encoding rules for CMove tests >> - Merge remote-tracking branch 'origin/master' into user/missa-prime/avx10_2 >> - Remove unnecessary CMOV blocks and adjust predicates involving APX and >> AVX10.2 >> - Remove extra jump instruction in signum floating point and unify >> three-way floating point comparison logic in x86.ad >> - Also update copyright year in IREncodingPrinter.java >> - Include apx_f in list of verified CPU features for IR encoding >> - Fix CMove IR tests to account for APX presence >> - Merge branch 'master' into user/missa-prime/avx10_2 >> - ... and 15 more: https://git.openjdk.org/jdk/compare/44b74e16...09d1e44d > > src/hotspot/cpu/x86/x86.ad line 6075: > >> 6073: operand cmpOpUCF() %{ >> 6074: match(Bool); >> 6075: predicate((!UseAPX || !VM_Version::supports_avx10_2()) && > > Is there a reason why the check is not an and like !UseAPX `&&` > !VM_Version::supports_avx10_2() ? We want to cover the cases where a platform has APX but not AVX10.2 and vice versa. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2729386788
