On Tue, 27 Jan 2026 21:11:05 GMT, Eirik Bjørsnøs <[email protected]> wrote:
> Please review this PR which updates a few JDK tests to not depend on the > existence of `java.lang.ref.ReferenceQueue$Lock` and > `java.lang.Shutdown$Lock` classes. These are suggested for removal in > JDK-8376477, see #29442. > > * `ClhsdbInspect` is updated to use add a nested Lock class in the sample app > and use that instead. > * `ConcurrentAssociateTest` and `Phaser/Basic` are updated to not use lock > name when filtering threads to dump for debugging purposes when failing. > * `ImageReaderBenchmark` micro is updated to remove these classes from the > list of expected system image resource names > > I have verified that these tests now run with or without the `Lock` classes > present in the JDK. I called the thread dump debug methods manually to verify > them since these only run on test failure. GHA run passes. > > Test only change/cleanup. `noreg-self` The core-libs related changes look fine. So do the others but serviceability review would be good. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29455#pullrequestreview-3716828194
