On Thu, 29 Jan 2026 08:09:36 GMT, Quan Anh Mai <[email protected]> wrote:
>> As per [discussions >> ](https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594) on >> JDK-8370691 pull request, splitting out portion of PR#28002 into a separate >> patch in preparation of Float16 vector API support. >> >> Patch add new lane type constants and pass them to vector intrinsic entry >> points. >> >> All existing Vector API jtreg test are passing with the patch. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin > > src/hotspot/share/prims/vectorSupport.hpp line 140: > >> 138: }; >> 139: >> 140: enum { > > Please use a scoped enum instead. Its contained in VectorSupport class which makes it implicitly scoped. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2740618259
