On Fri, 30 Jan 2026 15:21:39 GMT, Tatsunori Uchino <[email protected]> wrote:
>> test/jdk/java/lang/StringBuilder/Supplementary.java line 218: >> >>> 216: >>> 217: /** >>> 218: * Test codePointCount(int, int) & codePointCount() >> >> I think a separate test method needs to be added solely for >> `codePointCount()` to follow the pattern in this test file. Bonus if you >> could rename each `testX` to `testMethodName` >> (This test seems to have a lot of room for refactoring, but they are for >> another time) > >> Bonus if you could rename each testX to testMethodName > > "`testCodePointCount`" has already been occupied: > > https://github.com/tats-u/jdk/blob/585ce36e125ec2f79483311512d8789ff39b0df9/test/jdk/java/lang/StringBuilder/Supplementary.java#L365-L376 > > https://github.com/tats-u/jdk/blob/585ce36e125ec2f79483311512d8789ff39b0df9/test/jdk/java/lang/StringBuilder/Supplementary.java#L247-L251 We could distinguish them like `testCodePointCountNoArg` and `testCodePointCountTwoArgs` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26461#discussion_r2747019135
