On Mon, 2 Feb 2026 14:44:21 GMT, Roger Riggs <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert the change of lsof -p and only increase timeout value for test
>> - Revert "8376630: java/lang/ProcessBuilder/PipelineLeaksFD.java
>> intermittent timed out"
>>
>> This reverts commit 23d6dd1ae20bdd8957826f443a95bd4e69000eab.
>
> test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java line 243:
>
>> 241: .start()) {
>> 242: boolean status = p.waitFor(Utils.adjustTimeout(120),
>> TimeUnit.SECONDS);
>> 243: if (!status) {
>
> Retry on destroyForcibly isn't necessary or productive. On Linux its
> equivalent to 'kill -9' and on Windows it isn't conditional.
> If there is a case where the a single call isn't effective, that should be
> reported as a bug against `destroyForcibly`.
Thanks for the detail explanations. The retry destroyForcibly has been removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29478#discussion_r2756912369
