On Thu, 5 Feb 2026 14:39:51 GMT, David Beaumont <[email protected]> wrote:
> Updated legacy TestNG asserts to JUnit and added useful context to help
> debugging when assertions fail.
test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java line 192:
> 190: ouri.ifPresent(uri -> {
> 191: if (name.endsWith("/"))
> 192: assertTrue(uri.toString().endsWith("/"),
The assertions here are basically duplicated further down too.
They are, to all intents and purposes identical, and could be factored out if
desired.
test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java line 214:
> 212: assertThrows(IOException.class, () ->
> reader.open(BASE_RESOURCES[0]));
> 213: assertThrows(IOException.class, () ->
> reader.read(BASE_RESOURCES[0]));
> 214: assertThrows(IOException.class, reader::list);
Added seemingly missing case (present below, but not in this version).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29588#discussion_r2769547202
PR Review Comment: https://git.openjdk.org/jdk/pull/29588#discussion_r2769540083
