On Wed, 4 Feb 2026 06:53:48 GMT, David Holmes <[email protected]> wrote:
>> SendaoYan has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 31 additional commits >> since the last revision: >> >> - Fix missed attempt++ >> - Add "import jdk.test.lib.classloader.CustomClassLoader;" for >> vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/TestDescription.java >> etc.. >> - Adapt DEFAULT_BREAKPOINT_LINE from 63 to 65, since two lines added to >> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/AbstractDebuggeeTest.java >> - Add "import jdk.test.lib.classloader.ClassFileFinder" >> - fix >> vmTestbase/nsk/jdi/Scenarios/invokeMethod/redefineclasses001/TestDescription.java >> fails "cannot find symbol ClassFileFind" >> - sed -i "s|import nsk.share.CustomClassLoader;|import >> jdk.test.lib.classloader.CustomClassLoader;|" `grep >> nsk.share.CustomClassLoader test/ -rnl ` >> - Fix >> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassUnloadEvent/className/classname001/TestDescription.java >> fails "cannot find user-defined classloader loaded: >> nsk.share.CustomClassLoader" >> - Fix javac error: "AbstractDebuggeeTest.java:103: error: cannot find >> symbol" >> - Merge branch 'openjdk:master' into jbs8376023 >> - Fix comment in >> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype002/TestDescription.java >> - ... and 21 more: https://git.openjdk.org/jdk/compare/717f7a39...bff25ebf > > test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java line 30: > >> 28: * @requires vm.flagless >> 29: * @modules java.base/jdk.internal.misc >> 30: * @library /test/lib /vmTestbase > > This test should not be using anything in vmTestbase! I remove the nsk.share dependences in test/lib/jdk/test/lib/classloader/ClassUnloadCommon.java, and this @library /vmTestbase has been removed. But I need move CustomClassLoader.java/ClassFileFinder.java/Failure.java to test/lib/jdk/test/lib/classloader. There must be some vmTestbase tests needed to adapt since this move. I'am wondering should I continue this PR or not. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29545#discussion_r2762697432
