On Sat, 7 Feb 2026 04:21:41 GMT, SendaoYan <[email protected]> wrote:

> > I'm just wondering if this change is worth doing if there is no added code 
> > sharing going on. What is the motivation for this?
> 
> I agree with you. Maybe I misunderstood the intention of 
> [JDK-8376023](https://bugs.openjdk.org/browse/JDK-8376023)
> 
> @coleenp Could you give me some advies?

I think the suggestion was to merge the functionality, not just combine the 
similar but different functionality into the same class. In other words, all 
tests should use common APIs to handle class unloading, not different methods 
that happen to be in the same class. Given the differences you have found in 
the two implementations and how they are used by the tests, I'm not so sure the 
disruption to the tests (and risk of introducing bugs) is worth it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29545#issuecomment-3875177130

Reply via email to