On Tue, 10 Feb 2026 09:33:23 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which proposes to improve the > exception reported by > `jdk.nio.zipfs.ZipFileSystemProvider.newFileSystem(...)` methods when a > `ZipException` occurs for invalid ZIP files? This addresses > https://bugs.openjdk.org/browse/JDK-8377049. > > As noted in that issue the file whose `ZipException` wasn't being propagated > was a JMOD file. The change here will now propagate the `ZipException` for > JMOD files similar to ZIP and JAR files. The comments in that JBS issue has > additional discussion about this change. > > A new jtreg test has been introduced to verify this change. src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java line 125: > 123: // file. for others, raise a UnsupportedOperationException. > 124: String fname = path.getFileName().toString(); > 125: // JMOD files are expected to have (case sensitive) .jmod > extension I don't think this is strictly true but unlikely that there are JMOD files with the extension in upper case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29646#discussion_r2787147737
