On Fri, 6 Feb 2026 18:33:17 GMT, Jatin Bhateja <[email protected]> wrote:
> As per https://github.com/openjdk/jdk/pull/28002#issuecomment-3789507594 on > JDK-8370691 pull request, splitting out portion of PR#28002 into a separate > patch. > > In preparation of Float16 vector API support, changes to nomenclature of > concrete vector class by suffixing the vector type with vector bit sizes e.g. > FloatVector256 so that we don't end up generating names like Float16256Vector. > > All existing Vector API jtreg test are passing with the patch. > > Kindly review and share your feedback. > > Best Regards, > Jatin test/jdk/jdk/incubator/vector/gen-tests.sh line 61: > 59: args="-K$type -Dtype=$type -DType=$Type -DTYPE=$TYPE" > 60: > 61: VectorPrefix=$Type This seems unnecessary - why do we need it? test/jdk/jdk/incubator/vector/gen-tests.sh line 127: > 125: abstractvectortype=${typeprefix}${VectorPrefix}Vector > 126: abstractvectorteststype=${typeprefix}${VectorPrefix}VectorTests > 127: abstractbitsvectortype=${typeprefix}${VectorPrefixe}Vector Suggestion: abstractbitsvectortype=${typeprefix}${VectorPrefix}Vector But, why is it changed from ${Bitstype}? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2789562537 PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2789551075
