On Wed, 11 Feb 2026 23:51:11 GMT, Sergey Bylokhov <[email protected]> wrote:

> Not sure where you found that info, but the builds that are available here on 
> GitHub don't necessarily represent builds made by those who build and 
> distribute JDK binaries.

That's kind of the point @mrserb is making.  Your binaries may need this 
license, but you have made a change which affects **everyone** building OpenJDK.

> The changes to the makefiles was already done in JDK-8351603.

These are changes to the devkit build, which is something that has to be 
manually invoked separately from the OpenJDK build.  The change you've made 
here will bundle the GCC license in every build. 

This file was included on a build I just did on GNU/Linux with clang:
~~~
configure:108447: Using clang C compiler version 20.1.8 [clang version 20.1.8 ( 
20.1.8-2.module+el8.10.0+23372+3f2ea6fa) Target: x86
_64-redhat-linux-gnu]
configure:108573: checking for C compiler version
configure:108582: /usr/bin/clang --version >&5
clang version 20.1.8 ( 20.1.8-2.module+el8.10.0+23372+3f2ea6fa)
...
configure:111815: Using clang C++ compiler version 20.1.8 [clang version 20.1.8 
( 20.1.8-2.module+el8.10.0+23372+3f2ea6fa) Target: x86_64-redhat-linux-gnu]
configure:111936: checking for C++ compiler version
configure:111945: /usr/bin/clang++ --version >&5
clang version 20.1.8 ( 20.1.8-2.module+el8.10.0+23372+3f2ea6fa)

$ ls -l ~/builder/26u/images/jdk/legal/java.base/gcc.md
-r--r--r--. 1 andrew people 128099 Feb 13 15:02 
/home/andrew/builder/26u/images/jdk/legal/java.base/gcc.md
~~~
I haven't checked Windows & Mac but I presume this would also get bundled there 
too, where, again, gcc is not even being used.  I don't see anything in this PR 
that would prevent that from happening.

I don't see an explanation in this PR or the bug as to **why** this license is 
now needed.  `gcc` has been used to build for a long time, but this is not 
updating an existing license, but adding it.  So I presume something from `gcc` 
is now being bundled which requires this.  If so, inclusion of this license 
should be tied to whatever that option is.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29661#issuecomment-3897974725

Reply via email to