On Tue, 10 Feb 2026 10:05:31 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this change which proposes to prevent the 
> `NullPointerException` thrown from 
> `com.sun.jndi.ldap.sasl.SaslOutputStream.write()` methods when the stream is 
> already closed? This addresses https://bugs.openjdk.org/browse/JDK-8377486.
> 
> As noted in that issue, `OutputStream.write(...)` is specified to throw an 
> `IOException` in such cases. The change in this PR updates the 
> `SaslOutputStream.write()` methods to throw an `IOException` when closed.
> 
> A new test has been introduced to verify this change.

Looks reasonable to me. However, is it possible that close() is called 
asynchronously? If not then the proposed fix looks fine.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29647#pullrequestreview-3814402630

Reply via email to