On Tue, 27 Jan 2026 09:30:54 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Add code comment about returning the most recently used Inflater from the
>> cache
>> - Replace polling-style iteration with simple for loop
>> - Using add instead of addLast seems more natural for a List
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 764:
>
>> 762:
>> 763: // Close streams, release their inflaters
>> 764: if (istreams != null) {
>
> Small additional fix to remove unnecessary null check of the final,
> definitely assigned field `istreams`.
>
> Unrelated to issue at hand, included here since it is close code and to avoid
> the PR churn for such a trivial cleanup if fixed separately.
This looks good to me. The null check appears to be an oversight in the
original implementation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29430#discussion_r2833047049
