On Fri, 21 Nov 2025 13:47:16 GMT, Doug Lea <[email protected]> wrote: >> Vladimir Yaroslavskiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements >> >> * Added @java.io.Serial >> * Added information about the best data types for thresholds of sorting >> * Added comments about native implementation based on AVX512 instructions > > Some general comments: > > The structure intrinsically gets more complicated and harder to read as > options and sub-options increase -- 6 kinds of sorts, some with parallel > and/or SIMD, some only applying to some element types, almost all of them > with incremental improvements. I think the attempts to better organize these > is OK, but the main DualPiviotQuicksort should include a brief account > similar to the wording in the PR intro to better explain how the dispatching > criteria and logic. And perhaps a summary of constants and thresholds, with > notes on sensitivity of values. > > The changes related to parallel sorting all look good to me. I didn't read > the other parts in detail
Hi @DougLea Doug Lea, @jatin-bhateja, @jbhateja Jatin Bhateja, @tarsa Piotr Tarsa! Please review the final sources. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27411#issuecomment-3961583808
