On Thu, 26 Feb 2026 06:34:28 GMT, David Holmes <[email protected]> wrote:
>> jdk.test.lib.Platform.isMusl() may return false on Alpine linux, where it
>> should return true.
>> This means that the jtreg tests is is used to guard will incorrectly fail.
>> This happens when tests deliberately clobber the PATH and `ldd` can no
>> longer be found. This PR uses a full path for `ldd` instead to work around
>> the issue.
>
> test/lib/jdk/test/lib/Platform.java line 196:
>
>> 194: ProcessBuilder pb = new ProcessBuilder(lddPath.get(),
>> "--version");
>> 195: pb.redirectErrorStream(true);
>> 196: try (Process p = pb.start()) {
>
> `Process` is not `AutoCloseable` - why are you using try-with-resources?
`Process` implements `Closable` since
https://bugs.openjdk.org/browse/JDK-8364361
Although on second thought, I agree it is worth considering whether or not we
want to do this here, as it will make backporting this change less straight
forward.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29923#discussion_r2857584081
