On Fri, 27 Feb 2026 19:52:03 GMT, Justin Lu <[email protected]> wrote:
>> This PR migrates the java/util/jar tests to use _JUnit_. >> >> https://github.com/openjdk/jdk/commit/afe0aeee746bccbbe4bc6c9a8cd2302228ecc2f6 >> includes changes for _testNG_ based tests. >> https://github.com/openjdk/jdk/commit/c5a7f75840f96fa77ec3ed7faa713990adb84de6 >> includes changes for `main` based tests. >> >> Before: Framework-based tests: 125 = 125 TestNG + 0 JUnit. >> After: Framework-based tests: 174 = 0 TestNG + 174 JUnit > > Justin Lu has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains eight additional commits since > the last revision: > > - Merge branch 'master' into junit-java-util-jar > - Reflect Lance's comments > - get rid of inheritance + zip -> ZIP > - Eirik comments > - Naoto comment > - Andrey comments > - main -> JUnit > - TestNG -> JUnit test/jdk/java/util/jar/TestExtra.java line 62: > 60: > 61: // Use byte arrays instead of files > 62: ByteArrayOutputStream baos = new ByteArrayOutputStream(); Suggestion: ByteArrayOutputStream baos = new ByteArrayOutputStream(); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29828#discussion_r2869801680
