On Fri, 27 Feb 2026 23:11:36 GMT, Justin Lu <[email protected]> wrote:

>> Locale APIs which accept BCP 47 tags use hyphen for multiple variant 
>> subtags. Locale APIs that accept multiple (non BCP 47 subtag) variants use 
>> underscores. For example,
>> 
>> `Locale.of` supports multiple variants separated by underscore.
>> `Locale.forLanguageTag` supports multiple variants separated by hyphen.
>> `Locale.Builder.setLanguageTag` supports multiple variants separated by 
>> hyphen.
>> `Locale.Builder.setVariant` supports multiple variants separated by either 
>> underscore or hyphen. 
>> 
>> The current wording is not detailed enough and implies both formats are 
>> interchangeable within `Locale`. This PR updates the wording to make this 
>> more apparent. Note that I left the constructor behavior out in the new 
>> wording as to not call attention to it.
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Describe basis for underscore support

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29970#pullrequestreview-3877674950

Reply via email to