On Wed, 25 Feb 2026 02:09:13 GMT, Alexey Semenyuk <[email protected]> wrote:
> Change how jpackage embeds icons, version and other properties in .exe files.
> Don't print
>
> Warning: Windows Defender may prevent jpackage from functioning. If there is
> an issue, it can be addressed by either disabling realtime monitoring, or
> adding an exclusion for the directory <TMPDIR>.
>
>
> warning. Instead, run the operation with retries.
>
> Additionally, throw JPackageException instead of RuntimeException to report
> errors; fail if invalid data is passed in the ctor instead of logging and
> ignoring it.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/ExecutableRebrander.java
line 220:
> 218: Objects.requireNonNull(v);
> 219: if (v.contains("\r") || v.contains("\n")) {
> 220: throw new IllegalArgumentException("Configuration parameter
> contains multiple lines of text");
Should we have localized error for user input?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29906#discussion_r2875508765
